Skip to content

Conversation

@linoytsaban
Copy link
Collaborator

@linoytsaban linoytsaban commented Apr 30, 2025

make lora_alpha and lora_dropout configurable for lora training,
if not provided, sets by default lora_alpha to the value of --rank to maintain current behaviour

edit: this PR will only make lora_dropout configurable until #11324 is merged to handle inference with lora_rank != lora_alpha

@linoytsaban
Copy link
Collaborator Author

@bot /style

@github-actions
Copy link
Contributor

Style fixes have been applied. View the workflow run here.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@linoytsaban
Copy link
Collaborator Author

@bot /style

@linoytsaban linoytsaban requested review from asomoza and sayakpaul May 2, 2025 08:40
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

Style fixes have been applied. View the workflow run here.

@sayakpaul
Copy link
Member

Thanks for this effort!

LoRA dropout is okay to configure for now but using a different lora_alpha will have an adverse effect on inference without #11324. Let's revisit after #11324 is merged?

@linoytsaban
Copy link
Collaborator Author

good point! I thought we handled inference, will revert lora_alpha

@linoytsaban
Copy link
Collaborator Author

@bot /style

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Style fixes have been applied. View the workflow run here.

@linoytsaban
Copy link
Collaborator Author

@sayakpaul I think we can merge this?

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's maybe add an empty commit to retrigger the CI before merging?

@linoytsaban linoytsaban merged commit 66e50d4 into huggingface:main May 8, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants