Skip to content

Conversation

@AMEERAZAM08
Copy link
Contributor

@AMEERAZAM08 AMEERAZAM08 commented May 28, 2025

What does this PR do?

Fixes # (issue)

Before submitting

Who can review?

@sayakpaul ,@yiyixuxu and @asomoza

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@AMEERAZAM08
Copy link
Contributor Author

AMEERAZAM08 commented May 28, 2025

Hi @sayakpaul ,
Please take a look at this PR, thank you for your help :)

@sayakpaul sayakpaul requested a review from DN6 May 28, 2025 15:19
@AMEERAZAM08
Copy link
Contributor Author

AMEERAZAM08 commented May 30, 2025

@DN6 @a-r-r-o-w please review this PR ,
Thanks

@AMEERAZAM08
Copy link
Contributor Author

@sayakpaul Any other can review this

Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is an excessive amount of unrelated changes that make this PR hard to review. Could you please rebase with main such that only the changes related to PhotoDoodle persist? You can follow some of the past PRs for an example on the expected changes: #10660, #11428, #10136

Additionally, I think if we tried shipping this in the community projects folder, we could review it faster

@AMEERAZAM08
Copy link
Contributor Author

AMEERAZAM08 commented Jun 2, 2025

I wanted to merge in diffuser
it can easily
import diffusers from PhotoDoodlePipeline
@a-r-r-o-w Now Updated .

@AMEERAZAM08 AMEERAZAM08 requested a review from a-r-r-o-w June 2, 2025 05:25
@AMEERAZAM08
Copy link
Contributor Author

Hi @DN6 , @a-r-r-o-w change has been done

@AMEERAZAM08
Copy link
Contributor Author

@a-r-r-o-w can you review this we need it in diffusers pipeline
cc: @sayakpaul

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu June 12, 2025 15:01
@a-r-r-o-w
Copy link
Contributor

@yiyixuxu Could you take a look here/test if you have the bandwidth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants