Skip to content

Conversation

@Promisery
Copy link

@Promisery Promisery commented Jun 6, 2025

What does this PR do?

In the scale_noise functions of all flow matching schedulers, the definitions and docs are wrong:

  • timestep should be a torch.FloatTensor, not a float or int
  • noise is not included in the document

Also, noise should be a required arg

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yiyixuxu

@DN6 DN6 requested a review from yiyixuxu June 11, 2025 08:38
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR
I left one feedback

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Promisery Promisery requested a review from yiyixuxu June 13, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants