Skip to content

Conversation

@tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Jun 15, 2025

While working on MAGI-1, I came across these. I thought that understandability is important, so I propose fixing tensor shapes in the comments.

@yiyixuxu @a-r-r-o-w @ylacombe

@tolgacangoz tolgacangoz changed the title Fix dimensionality in apply_rotary_emb functions' comments Fix dimensionalities in apply_rotary_emb functions' comments Jun 15, 2025
@tolgacangoz tolgacangoz marked this pull request as draft June 16, 2025 04:46
@tolgacangoz tolgacangoz marked this pull request as ready for review June 17, 2025 13:29
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit 7fc53b5 into huggingface:main Jun 21, 2025
12 checks passed
@tolgacangoz
Copy link
Contributor Author

Thanks for merging!

@tolgacangoz tolgacangoz deleted the fix-dimensions-rope branch June 22, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants