Skip to content

Conversation

@bennyguo
Copy link
Contributor

@bennyguo bennyguo commented Jun 23, 2025

What does this PR do?

Fixes #11779

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bennyguo, you're absolutely right! I checked again and see that I made a mistake initially: https://github.com/ali-vilab/VACE/blob/0897c6d055d7d9ea9e191dce763006664d9780f8/vace/models/wan/wan_vace.py#L187

Thanks for the fix!

@bennyguo
Copy link
Contributor Author

@a-r-r-o-w Insane response speed! Cheers :)

@bennyguo bennyguo closed this Jun 23, 2025
@bennyguo bennyguo reopened this Jun 23, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@a-r-r-o-w a-r-r-o-w merged commit 798265f into huggingface:main Jun 23, 2025
17 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect mask padding in Wan VACE pipeline

3 participants