[chore] raise as early as possible in group offloading #11792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-r-r-o-w
reviewed
Jun 24, 2025
| onload_self: bool = True, | ||
| offload_to_disk_path: Optional[str] = None, | ||
| ) -> None: | ||
| if stream is None and record_stream: |
There was a problem hiding this comment.
We can remove this completely, no? It's not supposed to be user facing and now apply_group_offloading handles the error case too
There was a problem hiding this comment.
We can but since ModuleGroup is a public class I thought of keeping it.
There was a problem hiding this comment.
Not really, it's not a public class - no user is expected to import it or that we document it that way. We don't necessarily need to mark every internal data structure private to imply it shouldn't be used by users
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.