Skip to content

Conversation

@Brvcket
Copy link
Contributor

@Brvcket Brvcket commented Jul 6, 2025

There were 4 issues fixed:

  1. When sampling with prior preservation, the prompt was not passed to the correct argument position, causing a generation error during sampling.
  2. When sampling with prior preservation, the transformer passed to the pipeline did not have the torch_dtype argument, causing issues with mixed precision.
  3. When sampling with prior preservation, the prompt was passed in fp32 without proper casting, leading to mixed precision mismatches.
  4. When not args.train_text_encoder, prompt_embeds and pooled_prompt_embeds were None, leading to the same error as reported in RuntimeError: The size of tensor a (4608) must match the size of tensor b (5120) at non-singleton dimension 2 during DreamBooth Training with Prior Preservation #10722.

@Brvcket
Copy link
Contributor Author

Brvcket commented Jul 16, 2025

@linoytsaban Am I correct in assuming that your review is required? I'm sorry if I tagged the wrong person

@linoytsaban
Copy link
Collaborator

thanks @Brvcket!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@linoytsaban linoytsaban requested a review from sayakpaul August 29, 2025 15:19
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@linoytsaban linoytsaban merged commit 0ff1aa9 into huggingface:main Sep 1, 2025
25 checks passed
linoytsaban added a commit to linoytsaban/diffusers that referenced this pull request Sep 1, 2025
linoytsaban added a commit to linoytsaban/diffusers that referenced this pull request Sep 1, 2025
linoytsaban added a commit to linoytsaban/diffusers that referenced this pull request Sep 1, 2025
linoytsaban added a commit that referenced this pull request Sep 2, 2025
…follow up on #11873 (#12264)

* propagate fixes from #11873 to flux script

* propagate fixes from #11873 to flux script

* propagate fixes from #11873 to flux script

* Apply style fixes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants