Skip to content

Conversation

@yiyixuxu
Copy link
Collaborator

We guarantee unique component names under each collection, i.e. for each collection, there is only one "unet", one "vae" ....

Currently, when a new component enters the collection, we remove the existing one
e.g. node1 has a "unet" that's sdxl default, when we add a new unet from node1, say "CyberRealisticXL", the sdxl default unet will be removed from the components manager

This is wrong, and this PR changes the behavior so that we simply dissociate the existing from the collection, and won't delete it if the component is still associated with a different collection

@yiyixuxu yiyixuxu requested a review from asomoza July 21, 2025 01:10
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@asomoza
Copy link
Member

asomoza commented Jul 21, 2025

LGTM, thanks!

@yiyixuxu yiyixuxu merged commit 638cc03 into main Jul 21, 2025
15 checks passed
@yiyixuxu yiyixuxu deleted the modular-collection-fix branch July 21, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants