- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.5k
feat: cuda device_map for pipelines. #12122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 8 commits
      Commits
    
    
            Show all changes
          
          
            11 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      eba6f82
              
                feat: cuda device_map for pipelines.
              
              
                sayakpaul b4483cc
              
                Merge branch 'main' into cuda-device-map-pipe
              
              
                sayakpaul 7228ab8
              
                Merge branch 'main' into cuda-device-map-pipe
              
              
                sayakpaul a31e59e
              
                up
              
              
                sayakpaul 30c575b
              
                up
              
              
                sayakpaul 0ab1d9e
              
                Merge branch 'main' into cuda-device-map-pipe
              
              
                sayakpaul 3dd4fb2
              
                empty
              
              
                sayakpaul 8448bdf
              
                Merge branch 'main' into cuda-device-map-pipe
              
              
                sayakpaul f657b6b
              
                up
              
              
                sayakpaul 5e6f142
              
                Merge branch 'main' into cuda-device-map-pipe
              
              
                sayakpaul 736971c
              
                Merge branch 'main' into cuda-device-map-pipe
              
              
                sayakpaul File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not to import from
testing_utilsfor non-test modules (in fact we should move this module out of src). It would be better to redefine the relevanttorch_devicefunctionality intorch_utilsand import from there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah my thoughts too. We should actually move
torch_devicetoutils.