Skip to content

Conversation

@SlimRG
Copy link
Contributor

@SlimRG SlimRG commented Aug 13, 2025

What does this PR do?

Fix problem with vae, when vae's dtype != float32

Fixes #12141

Before submitting

Who can review?

@yiyixuxu and @asomoza

Maybe:
@DN6 @a-r-r-o-w
@sayakpaul @yiyixuxu

-->

@SlimRG
Copy link
Contributor Author

SlimRG commented Aug 13, 2025

Make fix in single line as you wanted =)

@a-r-r-o-w
Copy link
Contributor

There's one line above the line you added that also performs a dtype cast and is now redundant. Could you remove that?

@SlimRG
Copy link
Contributor Author

SlimRG commented Aug 13, 2025

There's one line above the line you added that also performs a dtype cast and is now redundant. Could you remove that?

There's one line above the line you added that also performs a dtype cast and is now redundant. Could you remove that?

Done

Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@a-r-r-o-w
Copy link
Contributor

@SlimRG I pushed a change because I believe your PR fixes a failing test we've had for a while marked xfail. With this change, things pass locally so waiting to see if it passes on our CI as well

@a-r-r-o-w
Copy link
Contributor

Okay perfect, it passes!

@a-r-r-o-w a-r-r-o-w merged commit 8c48ec0 into huggingface:main Aug 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WanVACEPipeline doesn't work with bfloat16/foat16 vae

3 participants