- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.5k
remove silu for CogView4 #12150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove silu for CogView4 #12150
Conversation
…AdaLayerNormContinuous; split temb_raw/temb_blocks
…AdaLayerNormContinuous; split temb_raw/temb_blocks
…AdaLayerNormContinuous; split temb_raw/temb_blocks
| This is a small CogView4 alignment fix: CogView4: remove the SiLU right before the final AdaLN. Why In Megatron (our reference), adaln_final is a plain Linear (no activation). | 
| @a-r-r-o-w can you check this | 
| Instead of making this change here, can we just copy the layer into the CogView transformer files where required and use the correct code? | 
| “CogView4-only fix: final AdaLN without SiLU to match Megatron; generic normalization remains unchanged.” | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lambertwjh, looks good. I'm adding some changes to update the layer names.
| @bot style | 
| The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. | 
| @bot /style | 
| Style bot fixed some files and pushed the changes. | 
| @lambertwjh @zRzRzRzRzRzRzR Just to confirm, do the changes for the layer name look good to you? If so, I'll merge this :) | 
| Looks good to me. The rename to CogView4AdaLayerNormContinuous is clearer and matches the CogView4-only usage. Thanks! @a-r-r-o-w | 
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.