Skip to content

Conversation

@sayakpaul
Copy link
Member

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul marked this pull request as ready for review August 15, 2025 03:55
@sayakpaul sayakpaul requested review from DN6 and yiyixuxu August 15, 2025 03:55
@sayakpaul sayakpaul changed the title [wip] Deprecate Flax support Deprecate Flax support Aug 15, 2025
dtype: jnp.dtype = jnp.float32

def setup(self):
logger.warning(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought of adding it to all the public Flax classes, can remove.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@sayakpaul
Copy link
Member Author

@DN6 should we consider removing JAX and Flax from setup.py as well?

@sayakpaul
Copy link
Member Author

Over to you, @yiyixuxu :)

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank yoU!

@sayakpaul
Copy link
Member Author

Failing test is unrelated.

@sayakpaul sayakpaul merged commit 532f41c into main Aug 26, 2025
18 of 19 checks passed
@sayakpaul sayakpaul deleted the deprecate-jax branch August 26, 2025 07:58
@DN6
Copy link
Collaborator

DN6 commented Aug 26, 2025

@sayakpaul Can do in a follow up, but we also need to make torch a required dep.

@stevhliu stevhliu mentioned this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants