[qwen] Qwen image edit followups #12166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Aug 17, 2025
| video_freq = self.rope_cache[rope_key] | ||
| else: | ||
| video_freq = self._compute_video_freqs(frame, height, width, idx) | ||
| video_freq = video_freq.to(device) |
There was a problem hiding this comment.
Without this, the test_to_device test fails:
sayakpaul
commented
Aug 17, 2025
Comment on lines
-638
to
+645
| calculated_width, calculated_height, _ = calculate_dimensions(1024 * 1024, image.width / image.height) | ||
| image_size = image[0].size if isinstance(image, list) else image.size | ||
| width, height = image_size | ||
| calculated_width, calculated_height, _ = calculate_dimensions(1024 * 1024, width / height) |
There was a problem hiding this comment.
Otherwise, test_inference_batch_consistent fails.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
approved these changes
Aug 17, 2025
| def prepare_dummy_input(self, height, width): | ||
| return QwenImageTransformerTests().prepare_dummy_input(height=height, width=width) | ||
|
|
||
| @pytest.mark.xfail(condition=True, reason="RoPE needs to be revisited.", strict=True) |
There was a problem hiding this comment.
Makes sense since RoPE refactor changes have been reverted
naykun
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
Hi @sayakpaul, thank you for your support. The changes look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For Qwen Image Edit:
Some inline comments.
Cc: @naykun as well. Could you review?