Skip to content

[chore] remove extra validation check in determine_device_map #12176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2025
Merged

[chore] remove extra validation check in determine_device_map #12176

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5baa965
remove extra validation check in determine_device_map
sayakpaul Aug 18, 2025
ef44689
Merge branch 'main' into remove-extra-validation
sayakpaul Aug 20, 2025
068ddac
Merge branch 'main' into remove-extra-validation
sayakpaul Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/diffusers/models/model_loading_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ def _determine_device_map(
device_map_kwargs["max_memory"] = max_memory
device_map = infer_auto_device_map(model, dtype=target_dtype, **device_map_kwargs)

if hf_quantizer is not None:
hf_quantizer.validate_environment(device_map=device_map)

Comment on lines -115 to -117
Copy link
Member

@SunMarc SunMarc Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove that ?

Copy link
Member Author

@sayakpaul sayakpaul Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because:
https://github.com/huggingface/diffusers/blob/7a2b78bf0f788d311cc96b61e660a8e13e3b1e63/src/diffusers/models/modeling_utils.py#L1278C9-L1280C1

Copy link
Member

@SunMarc SunMarc Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh indeed ;)

return device_map


Expand Down