-
Notifications
You must be signed in to change notification settings - Fork 6.5k
[Qwen-Image] adding validation for guidance_scale, true_cfg_scale and negative_prompt #12223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @naykun |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I've tested locally and everything appears to be working correctly. Thank you @yiyixuxu ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Should propagate this to other Qwen-Image pipelines as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! Looks all good to me but maybe we can also change also the example as correctly pointed here by @vagitablebirdcode
This PR adds the parameter validation for guidance_scale/true_cfg_scale/negative_prompt and try to improve user experience for the QwenImagePipeline
Behavior for Non-guidance-distilled models:
None, it will be ignored with warning if providednegative_promptprovided (by default not provided) ANDtrue_cfg_scale > 1(defaults to be4.0)true_cfg_scale > 1but nonegative_promptnegative_promptprovided buttrue_cfg_scale <= 1test script
outputs
Behavior for Guidance-distilled models
(currently we don't have a guidance-distilled qwen-image checkpoint, but the team might release on in the future)