Skip to content

Conversation

@samutamm
Copy link

@samutamm samutamm commented Sep 11, 2025

What does this PR do?

Recently 8907a70 replaced in HunyuanVideo pipeline CombinedTimestepGuidanceTextProjEmbeddings by improved embedding class HunyuanVideoConditionEmbedding. As a side-effect, the output conditioning = timesteps_emb + guidance_emb + pooled_projections became conditioning = timesteps_emb + pooled_projections + guidance_emb. This caused some tiny inconvenient differences in floating point operations and the output videos were altered.

This PR re-orders the addition of those tensors to be same as in CombinedTimestepGuidanceTextProjEmbeddings.

Fixes # (issue)
#12273

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@yiyixuxu @a-r-r-o-w

Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@a-r-r-o-w
Copy link
Contributor

cc @yiyixuxu

@eppaneamd
Copy link

@a-r-r-o-w @yiyixuxu any updates regarding merging this, any blockers? 👍

@samutamm
Copy link
Author

samutamm commented Oct 8, 2025

cc @sayakpaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants