-
Couldn't load subscription status.
- Fork 6.4k
[core] support QwenImage Edit Plus in modular #12416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ) | ||
| except EnvironmentError: | ||
| except EnvironmentError as e: | ||
| logger.debug(f"EnvironmentError: {e}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this is okay?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| block_state.img_shapes = [ | ||
| [ | ||
| (1, height // components.vae_scale_factor // 2, width // components.vae_scale_factor // 2), | ||
| *[ | ||
| (1, vae_height // components.vae_scale_factor // 2, vae_width // components.vae_scale_factor // 2) | ||
| for vae_width, vae_height in vae_image_sizes | ||
| ], | ||
| ] | ||
| ] * block_state.batch_size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where this step differs from the existing RoPE input step.
| def inputs(self) -> List[InputParam]: | ||
| inputs_list = super().inputs | ||
| return inputs_list + [ | ||
| InputParam(name=self._image_size_output_name, required=True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!, this part is just for this model and when doing the denoise step alone and passing the image latents, it gives an error since the images_sizes input is missing.
ValueError: Required input 'image_sizes' is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, it works!
|
@asomoza if you tests are looking good, maybe we could merge it? If so, could you review and approve as you go? |
|
sure, I wanted to test and review with more scenarios but that will take more time and probably they're going to work, everything else looks good to me, if I find something after we can fix it in a following PR. |
|
Sure! Plese hit me up if any issue comes up. |
What does this PR do?
Test code:
Result: