Raise warning instead of error when imports are missing for custom code #12513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
check_importsindynamic_module_utilsdoesn't account for guarded imports in custom code. Instead of diffusers raising an error, we should just raise a warning to let the user know that modules might be missing. The custom code will error out on loading anyway if a needed module is missing. We shouldn't raise errors on our side due inaccurate parsing/interpretation of the code.This issue doesn't seem to happen when loading custom code directly from a local directory. I haven't investigated much further, but seems to imply that dynamic module loading might need a bit of work to be more robust/consistent.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.