-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix crash if tiling mode is enabled #12521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Wang, Yi A <[email protected]>
|
cuda should have similar issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR.
But before we go on reviewing it, could you please:
- Include an error trace that you get without the changes from this PR?
- Include an output with the changes from this PR?
- Additionally, the changes introduced in this PR seem non-intrusive to me. So, if you add comments to explain those changes, that'd be super nice.
Signed-off-by: Wang, Yi A <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
wo the change, crash like |
|
Thanks! What about the outputs? Cc: @asomoza if you wanna help test it out a bit? |
So, it doesn't work yet? |
it works, the other crash is because patch_size is not considered in tiling mode. in this model, it's 2. and this PR fix it. |
|
crash like
|
|
@sywangyi would you be able to post some outputs after applying the fix? |
|
tested it with a simple
edit: I correct myself, I did a silly mistake, this PR does fix the issue for the 5B, I'll do a comparison with main |
|
here they are: main (without tiling) 5bit2v__main_output.mp4PR with 5bit2v__pr_output.mp4 |

@sayakpaul @dg845 please help review, test script