-
Couldn't load subscription status.
- Fork 6.5k
[Model Card] standardize advanced diffusion training sd15 lora #7613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4572341
modelcard generation edit
chiral-carbon 832514d
add missed tag
chiral-carbon c49663a
fix param name
chiral-carbon 4420806
fix var
chiral-carbon 4e3e587
change str to dict
chiral-carbon fab8c37
add use_dora check
chiral-carbon 89b945d
use correct tags for lora
chiral-carbon 33766d6
make style && make quality
chiral-carbon 4f94387
Merge branch 'main' into advdiff
a-r-r-o-w 9689b11
Merge branch 'main' into advdiff
a-r-r-o-w File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it can be either a LoRA or a DoRA, we need to check if the
use_doraarg is True and adapt the tag accordingly(we check that in the line -
lora = "lora" if not use_dora else "dora":) )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, my bad for removing the check! thanks for pointing out, pushing it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just switch
"lora"in the tags here toloraand we're good to go 😊