-
Couldn't load subscription status.
- Fork 6.5k
Add support for XFormers in SD3 #8583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @yiyixuxu @sayakpaul , could you please take a moment to review this PR when you have time? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
Thanks! Could you also provide a test script for this so that we can run some tests? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
def test_sd3(model_path, prompt):
pipe = StableDiffusion3Pipeline.from_pretrained(model_path, torch_dtype=torch.float16).to('cuda')
pipe.enable_xformers_memory_efficient_attention()
image = pipe(prompt, negative_prompt='',
num_inference_steps=28, guidance_scale=7.5,
height=1024, width=768).images[0] |
|
@DN6 how should this test set be added? |
|
Do you mean adding a test script to the 'tests' folder for submission? |
…mers # Conflicts: # src/diffusers/models/attention_processor.py
|
Pipeline tests for xformers is handled via the
|
|
============================= test session starts ============================== done @sayakpaul @DN6 |
|
@CanvaChen Could you please run |
|
done @DN6 @sayakpaul ruff check examples scripts src tests utils benchmarks setup.py |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
Apologies for this delay. @DN6 could you give this a review? |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@CanvaChen I think this is still quite relevant. Would you maybe like to resolve the conflicts so that we can attempt a merge? |
# Conflicts: # src/diffusers/models/attention_processor.py
|
@sayakpaul @DN6 I have resolved the code conflicts and also incorporated the recent changes from JointAttnProcessor2_0. |
|
@DN6 could you please give this a review? |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
Failing tests are unrelated. |
* Add support for XFormers in SD3 * sd3 xformers test * sd3 xformers quality * sd3 xformers update --------- Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: YiYi Xu <[email protected]>
What does this PR do?
Add support for XFormers in SD3 (#8535)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul @yiyixuxu