Skip to content

Conversation

@KeepLost
Copy link

Fix an error that missing necessary argument

Fix an error that missing necessary argument
@DN6
Copy link
Collaborator

DN6 commented Jul 18, 2024

Hi @KeepLost change looks good. Thanks for catching 👍🏽 Could you run make style && make quality on your PR so that the quality checks pass.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@yiyixuxu yiyixuxu added close-to-merge and removed stale Issues that haven't received updates labels Dec 3, 2024
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Dec 3, 2024

@KeepLost
the PR is close to merge, just need make style & make quanlity so that CI can pass
would you be ok if we push directly into your PR, or ask a community member to finish it up?

let us know if you need any guidance for that too!

@KeepLost KeepLost closed this by deleting the head repository Jan 17, 2025
@a-r-r-o-w
Copy link
Contributor

cc @DN6 Seems like PR was closed because fork was deleted. I think this still needs to be fixed, no?

@KeepLost Sorry for the delay in looking into this! Would you be able to address YiYi's comment about running make style and open a new PR? If not, I can take it up and add you as a co-author of the commit. LMK what you'd prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants