Skip to content

Conversation

@faaany
Copy link
Contributor

@faaany faaany commented Sep 9, 2024

What does this PR do?

Followed by this PR

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Nov 16, 2024
@a-r-r-o-w a-r-r-o-w removed the stale Issues that haven't received updates label Nov 17, 2024
@faaany faaany marked this pull request as ready for review November 18, 2024 10:16
@faaany faaany marked this pull request as draft November 18, 2024 10:17
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil
Copy link
Member

Hi @faaany !
you can start undrafting and finalizing this PR since part 1 was merged. please make sure you apply all the reviewer comments from the first PR and make style before committing your changes 🤗

@faaany faaany marked this pull request as ready for review November 26, 2024 06:45
@IlyasMoutawwakil
Copy link
Member

Hi @faaany the code quality is failing again, please run make style

@IlyasMoutawwakil
Copy link
Member

@faaany I would like to merge this PR this week keeping the momentum from the first one.

@faaany
Copy link
Contributor Author

faaany commented Nov 28, 2024

@faaany I would like to merge this PR this week keeping the momentum from the first one.

thanks a lot! let me update it quickly.

@faaany
Copy link
Contributor Author

faaany commented Nov 28, 2024

done.

@IlyasMoutawwakil
Copy link
Member

@DN6

@DN6 DN6 merged commit 6b288ec into huggingface:main Nov 29, 2024
11 checks passed
lawrence-cj pushed a commit to lawrence-cj/diffusers that referenced this pull request Dec 4, 2024
* enable on xpu

* add 1 more

* add one more

* enable more

* add 1 more

* add more

* enable 1

* enable more cases

* enable

* enable

* update comment

* one more

* enable 1

* add more cases

* enable xpu

* add one more caswe

* add more cases

* add 1

* add more

* add more cases

* add case

* enable

* add more

* add more

* add more

* enbale more

* add more

* update code

* update test marker

* add skip back

* update comment

* remove single files

* remove

* style

* add

* revert

* reformat

* enable

* enable esingle g

* add 2 more

* update decorator

* update

* update

* update

* Update tests/pipelines/deepfloyd_if/test_if.py

Co-authored-by: Dhruv Nair <[email protected]>

* Update src/diffusers/utils/testing_utils.py

Co-authored-by: Dhruv Nair <[email protected]>

* Update tests/pipelines/animatediff/test_animatediff_controlnet.py

Co-authored-by: Dhruv Nair <[email protected]>

* Update tests/pipelines/animatediff/test_animatediff.py

Co-authored-by: Dhruv Nair <[email protected]>

* Update tests/pipelines/animatediff/test_animatediff_controlnet.py

Co-authored-by: Dhruv Nair <[email protected]>

* update float16

* no unitest.skipt

* update

* apply style check

* adapt style

---------

Co-authored-by: Sayak Paul <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* enable on xpu

* add 1 more

* add one more

* enable more

* add 1 more

* add more

* enable 1

* enable more cases

* enable

* enable

* update comment

* one more

* enable 1

* add more cases

* enable xpu

* add one more caswe

* add more cases

* add 1

* add more

* add more cases

* add case

* enable

* add more

* add more

* add more

* enbale more

* add more

* update code

* update test marker

* add skip back

* update comment

* remove single files

* remove

* style

* add

* revert

* reformat

* enable

* enable esingle g

* add 2 more

* update decorator

* update

* update

* update

* Update tests/pipelines/deepfloyd_if/test_if.py

Co-authored-by: Dhruv Nair <[email protected]>

* Update src/diffusers/utils/testing_utils.py

Co-authored-by: Dhruv Nair <[email protected]>

* Update tests/pipelines/animatediff/test_animatediff_controlnet.py

Co-authored-by: Dhruv Nair <[email protected]>

* Update tests/pipelines/animatediff/test_animatediff.py

Co-authored-by: Dhruv Nair <[email protected]>

* Update tests/pipelines/animatediff/test_animatediff_controlnet.py

Co-authored-by: Dhruv Nair <[email protected]>

* update float16

* no unitest.skipt

* update

* apply style check

* adapt style

---------

Co-authored-by: Sayak Paul <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants