Skip to content

[LoRA] fix dora test to catch the warning properly. #9627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2024
Merged

[LoRA] fix dora test to catch the warning properly. #9627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d298824
fix dora test.
sayakpaul Oct 9, 2024
64fb9fe
Merge branch 'main' into dora-tests
sayakpaul Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/lora/test_lora_layers_sdxl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,12 +619,12 @@ def test_integration_logits_multi_adapter(self):
@nightly
def test_integration_logits_for_dora_lora(self):
pipeline = StableDiffusionXLPipeline.from_pretrained("stabilityai/stable-diffusion-xl-base-1.0")
pipeline.load_lora_weights("hf-internal-testing/dora-trained-on-kohya")
pipeline.enable_model_cpu_offload()

logger = logging.get_logger("diffusers.loaders.lora_pipeline")
logger.setLevel(30)
with CaptureLogger(logger) as cap_logger:
pipeline.load_lora_weights("hf-internal-testing/dora-trained-on-kohya")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning gets raised when we load the DoRA weights. So, we need to put this line inside the context manager.

pipeline.enable_model_cpu_offload()
images = pipeline(
"photo of ohwx dog",
num_inference_steps=10,
Expand Down
Loading