Skip to content

[LoRA] allow big CUDA tests to run properly for LoRA (and others) #9845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Jan 10, 2025
Merged

[LoRA] allow big CUDA tests to run properly for LoRA (and others) #9845

merged 45 commits into from
Jan 10, 2025

Conversation

@sayakpaul
Copy link
Member

What does this PR do?

Some comments in-line.

@sayakpaul sayakpaul requested a review from DN6 November 2, 2024 11:46
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul mentioned this pull request Nov 12, 2024
Merged
a-r-r-o-w
a-r-r-o-w reviewed Nov 20, 2024
View reviewed changes
@sayakpaul sayakpaul requested a review from a-r-r-o-w November 22, 2024 06:34
DN6
DN6 reviewed Dec 2, 2024
View reviewed changes
@sayakpaul
Copy link
Member Author

@DN6 comments addressed. @a-r-r-o-w could you also check if we should consider other pipeline tests in this PR (Allegro, etc.)? Okay if we do that in a separate PR. LMK.

@sayakpaul sayakpaul requested a review from DN6 December 4, 2024 09:40
@sayakpaul
Copy link
Member Author

Gently pinging @DN6 and @a-r-r-o-w. I think these tests are important to run nightly.

a-r-r-o-w
a-r-r-o-w approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Off to @DN6

tests/pipelines/mochi/test_mochi.py

video = videos[0]
expected_video = torch.randn(1, 16, 480, 848, 3).numpy()
expected_video = torch.randn(1, 19, 480, 848, 3).numpy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

@sayakpaul sayakpaul mentioned this pull request Jan 7, 2025
Merged
@sayakpaul
Copy link
Member Author

@DN6 a gentle ping here.

@sayakpaul sayakpaul requested a review from hlky January 10, 2025 06:52
@sayakpaul sayakpaul merged commit a6f043a into main Jan 10, 2025
11 checks passed
@sayakpaul sayakpaul deleted the allow-flux-lora-tests branch January 10, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6 DN6 Awaiting requested review from DN6

2 more reviewers

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

@hlky hlky hlky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sayakpaul @HuggingFaceDocBuilderDev @DN6 @a-r-r-o-w @hlky