-
Couldn't load subscription status.
- Fork 6.5k
Add server example #9918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server example #9918
Conversation
examples/server/README.md
Outdated
| curl -X POST -H "Content-Type: application/json" --data '{"model": "something", "prompt": "a kitten in front of a fireplace"}' http://localhost:8000/v1/images/generations | ||
| ``` | ||
|
|
||
| ### Upgrading Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add some notes on the multi-threaded nature of this example and show some GPU utilization numbers with and without threading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'll add that in the next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice example! I think this would make the most sense under Inference techniques. You can add this doc to the toctree with the title, "Create a server".
Updates to README from code review Co-authored-by: Steven Liu <[email protected]>
|
I gave it my best shot at getting those docs in there. I think I did it correctly, but tbh, I am having trouble getting the docs up and running on my macbook 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left a few more comments. Your docs look great here :)
|
So just changing scheduler will do the thing, right? I am facing same issue where different clients cannot access the endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this example use case! 🤗
* Add server example. * Minor updates to README. * Add fixes after local testing. * Apply suggestions from code review Updates to README from code review Co-authored-by: Steven Liu <[email protected]> * More doc updates. * Maybe this will work to build the docs correctly? * Fix style issues. * Fix toc. * Minor reformatting. * Move docs to proper loc. * Fix missing tick. * Apply suggestions from code review Co-authored-by: Steven Liu <[email protected]> * Sync docs changes back to README. * Very minor update to docs to add space. --------- Co-authored-by: Steven Liu <[email protected]>
What does this PR do?
This is a followup to 9848. The aim of this is to serve as a fix for several issues around concurrent, multithreaded usage of diffusers:
Fixes #3672, #5749, #9833, #7851, #4920, #2916
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@yiyixuxu, anyone else that is interested