Replace inequality with non-identity for inspect._empty#211
Open
albertvillanova wants to merge 2 commits intohuggingface:mainfrom
Open
Replace inequality with non-identity for inspect._empty#211albertvillanova wants to merge 2 commits intohuggingface:mainfrom
albertvillanova wants to merge 2 commits intohuggingface:mainfrom
Conversation
Member
Author
|
The CI issue: https://github.com/huggingface/doc-builder/runs/6452663012?check_suite_focus=true has to do with the update of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
inspectpackage usesis/is not(instead of==/!=) withinspect._empty:__eq__/__ne__(with unexpected behavior).is/is notguarantees comparison based on object identity.See examples in
inspect:Note I discovered this issue because of
datasets.Version. I am also proposing an improvement in its implementation, but I think this PR makes sense anyway.