- 
                Notifications
    
You must be signed in to change notification settings  - Fork 41
 
[Tip] Add icons #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Tip] Add icons #601
Conversation
| 
           I'm adding victor as the reviewer since he is in charge of UI designs. 
 See https://huggingface.co/mishig/test-tips for all the current tip designs  
       | 
    
| 
           Added icons for the rest of the blockquote admonitions. Let me know what you think @gary149 !  
       | 
    
| 
           spacing looks a bit too large to me @enzostvs + how does it look with a single sentence going on multiple lines.  | 
    
| 
           the spacing looks weird to me but we can merge and we'll see in prod (as build is complex @enzostvs )  | 
    
| 
           Agreed, the icon isn't aligned with the text as well and too much space on the right, maybe could be 1,5 instead of 2,5 and add a   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI wise lgtm!
we could still improve it in the future, but stil cool to have the icons!
(IDK if linked to this PR, but while no "content", there is a big blank inside the component)
| 
           awesome, I will do some local testing and merge 🚀  | 
    
| 
           thanks all! 🙏  | 
    



Adds a "warning" and "lightbulb" icon for the Warning/Tip component as shown below. This helps add some more context to the current Tip component. I can also explicitly add a "Warning" and "Tip" label to the component if we like :)