-
Notifications
You must be signed in to change notification settings - Fork 373
WIP: Initial Xet docs (incomplete) #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@rajatarya @ylow just did an update of these docs. Few things to note:
@rajatarya I'm going to work in the screenshots of @ylow would you mind taking a look so far? I think we could use some help on the |
|
@julien-c we've (@rajatarya @ylow and myself) have been looking at these docs are thinking about a larger rewrite where we have a single entry point for all content related to storage with an emphasis on Xet as the default and LFS as legacy. The thinking being that from a reader's perspective it's somewhat odd to have a This would mean the current
(Xet architecture content would be moved to https://github.com/huggingface/xet-core for open source contributors) The order and exact content on each page would be determined through this PR and with review from everyone that has an interest in the current Does this sound reasonable to you, or should we continue to keep Xet documentation separate as we are in this PR? |
|
(@jsulz i'm stuck on something else today but will look tomorrow) |
|
@jsulz sorry about long response time. In my opinion the most natural progression would keep to keep this doc page separate but put it right before the storage limits one, like so:
Storage limits are really more about pricing, and we will update that one as well to add mentions of Xet and not just LFS (in a subsequent PR) Keeping this EDIT: Alternatively, it could also be named just "Xet"... |
julien-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a good start 🔥 let's iterate and ship a first version of this soon!
|
@rajatarya just did a pass based on all of the feedback so far. Only thing remaining is the |
|
I will write the security model section tomorrow morning. |
julien-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (after the filename change)
Co-authored-by: Julien Chaumond <[email protected]> Co-authored-by: Célina <[email protected]>
Co-authored-by: Julien Chaumond <[email protected]> Co-authored-by: Célina <[email protected]>
Co-authored-by: Célina <[email protected]>
hanouticelina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jsulz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Co-authored-by: Lucain <[email protected]> Co-authored-by: Julien Chaumond <[email protected]>

This is the PR for Xet Storage documentation. This PR currently has partial content, so not ready for review yet.