-
Notifications
You must be signed in to change notification settings - Fork 373
Update model release checklist #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Vaibhavs10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels a bit out of place in the pipeline tag section, specially so we talk about it here:
https://huggingface.co/docs/hub/en/model-release-checklist#writing-a-comprehensive-model-card
|
@Vaibhavs10 I see sooooo many models with missing licenses I think most basic info should be license + task tag. it's even worse because we don't know the license itself that we can't open PR, the author has to do it themselves. and this page sits right after /new so it's best to have licenses. |
pcuenca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested minor simplification / rewording.
She renamed the section and it now includes both pipeline tag and license, I think it's not too bad to consider both essential. |
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
Vaibhavs10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, suggestion to rewrite the space section in line with the paragraph above (since it talks about the same thing.
Co-authored-by: vb <[email protected]>
Added some best practices for things I come across that model publishers don't follow