Skip to content

Conversation

@merveenoyan
Copy link
Contributor

Added some best practices for things I come across that model publishers don't follow

@merveenoyan merveenoyan requested review from Vaibhavs10 and pcuenca May 2, 2025 12:20
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a bit out of place in the pipeline tag section, specially so we talk about it here:

https://huggingface.co/docs/hub/en/model-release-checklist#writing-a-comprehensive-model-card

@merveenoyan
Copy link
Contributor Author

@Vaibhavs10 I see sooooo many models with missing licenses I think most basic info should be license + task tag. it's even worse because we don't know the license itself that we can't open PR, the author has to do it themselves. and this page sits right after /new so it's best to have licenses.

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested minor simplification / rewording.

@pcuenca
Copy link
Member

pcuenca commented May 7, 2025

feels a bit out of place in the pipeline tag section

She renamed the section and it now includes both pipeline tag and license, I think it's not too bad to consider both essential.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, suggestion to rewrite the space section in line with the paragraph above (since it talks about the same thing.

@merveenoyan merveenoyan merged commit 8b78e63 into main May 7, 2025
2 checks passed
@merveenoyan merveenoyan deleted the merveenoyan-patch-1 branch May 7, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants