-
Notifications
You must be signed in to change notification settings - Fork 374
Create spaces-custom-domain.md #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
burtenshaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Can we merge this in? I was looking for information about custom domains on Spaces and couldn't find it. Also: as it turns out, if you add a custom domain to your Space, the |
Co-authored-by: Julien Chaumond <[email protected]> Co-authored-by: burtenshaw <[email protected]>
Good point @abidlabs! I think @Michellehbn is OOO, so I'll take the liberty to accept all suggestions and merge. My apologies Michelle! 🙏 Regarding your additional suggestion, in my opinion we can iterate in a new PR. |
|
needs to be added to the TOC otherwise users can't find it |
No description provided.