Fix entrypoint.sh and kenlm installation
#108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment if a custom handler is provided via a `HF_MODEL_ID` then the `requirements.txt` are not downloaded nor installed, meaning that the current cannot use custom handlers via Hugging Face Hub model IDs, meaning that this would only work on Inference Endpoints as the model is downloaded in advance, but for other partners that's not the case; meaning that the `entrypoint.sh` should handle these scenarios.
alvarobartt
changed the title
entrypoint.shentrypoint.sh and kenlm installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the installation of custom dependencies from a
requirements.txtfile when theHF_MODEL_IDis provided instead of theHF_MODEL_DIR, as those were neither downloaded nor installed, meaning that custom handlers were only working whenHF_MODEL_DIRis provided.At the moment if a custom handler is provided via a
HF_MODEL_IDthen therequirements.txtare not downloaded nor installed, meaning that the current cannot use custom handlers via Hugging Face Hub model IDs, meaning that this would only work on Inference Endpoints as the model is downloaded in advance, but for other partners that's not the case; meaning that theentrypoint.shshould handle these scenarios.Additionally, this PR also fixes the
kenlminstallation issues due to the minimum supported CMake version (already patched intransformersandkenlmbut not released yet).