Skip to content

pass generator instead of seed to diffusers #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

pass generator instead of seed to diffusers #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f16999e
is seed is in kwarg, pass generator instead
ErikKaum Oct 7, 2024
b06fc74
ruff lint
ErikKaum Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/huggingface_inference_toolkit/diffusers_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ def __call__(
prompt,
**kwargs,
):
# diffusers doesn't support seed but rather the generator kwarg
Copy link

@osanseviero osanseviero Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a link to https://github.com/huggingface/api-inference-community/blob/main/docker_images/diffusers/app/pipelines/text_to_image.py#L172-L176 for X-ref/having a source for the future?

Copy link
Member Author

@ErikKaum ErikKaum Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah lol, I just merged and after that this comment popped up. But I'll add it in a separate PR. I think it's a good idea to have the "paper trace"

if "seed" in kwargs:
seed = int(kwargs["seed"])
generator = torch.Generator().manual_seed(seed)
kwargs["generator"] = generator
kwargs.pop("seed")

# TODO: add support for more images (Reason is correct output)
if "num_images_per_prompt" in kwargs:
kwargs.pop("num_images_per_prompt")
Expand Down
Loading