Skip to content

Conversation

@Deep-unlearning
Copy link
Contributor

No description provided.

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but I'd like to get @Vaibhavs10's opinion/approval
also @Vaibhavs10 should we remove sanchit-gandhi/whisper-jax from demos? this PR does that

Copy link
Contributor

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks it looks good, yes Whisper-JAX has an issue w/ TPU's atm. Need to debug/ clear cache on demand there (which is non-trivial since we don't have full access cc: @pcuenca )

Good to merge tho 👍

@Vaibhavs10
Copy link
Contributor

btw @Deep-unlearning is Steven :p

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pcuenca
Copy link
Member

pcuenca commented Nov 15, 2024

which is non-trivial since we don't have full access

We should. Let me take a look (next week) and I'll update the docs.

@Vaibhavs10 Vaibhavs10 merged commit cd0e7c6 into main Nov 15, 2024
4 of 5 checks passed
@Vaibhavs10 Vaibhavs10 deleted the asr branch November 15, 2024 12:37
@julien-c
Copy link
Member

btw @Deep-unlearning is Steven :p

neat gh handle Steven 😆 what's your hf handle?

@Deep-unlearning
Copy link
Contributor Author

btw @Deep-unlearning is Steven :p

neat gh handle Steven 😆 what's your hf handle?

ahah thanks ! my hf handle is Steveeeeeeen, less neat tho :')

@julien-c
Copy link
Member

🤔

image

@Deep-unlearning
Copy link
Contributor Author

😬
Capture d’écran 2024-11-18 à 12 13 38

@Vaibhavs10
Copy link
Contributor

Very close:

image

@pcuenca
Copy link
Member

pcuenca commented Nov 18, 2024

The heart count needs to go up too :)

@Deep-unlearning
Copy link
Contributor Author

The heart count needs to go up too :)

Im working on it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants