Skip to content

Conversation

coyotte508
Copy link
Member

@coyotte508 coyotte508 commented Dec 3, 2024

I really couldn't get #1054 to work so I copied over @huggingface/hub to a new folder and removed stuff, and it works now 🤷

In follow up PR we may want to make this package a dependency of @huggingface/hub and @huggingface/gguf (cc @mishig25 @ngxson)

See also https://huggingface.co/spaces/DDUF/dduf-check

@coyotte508 coyotte508 changed the title @huggingface/blob package @huggingface/blob and @huggingface/dduf package Dec 3, 2024
@coyotte508 coyotte508 requested a review from ngxson December 3, 2024 11:30
@coyotte508 coyotte508 changed the title @huggingface/blob and @huggingface/dduf package @huggingface/blob and @huggingface/dduf packages Dec 3, 2024
@julien-c julien-c requested review from Wauplin and mishig25 December 3, 2024 11:37
Copy link
Member

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks!

Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! lets some nits

@coyotte508
Copy link
Member Author

Thanks for the reviews!

@coyotte508 coyotte508 merged commit d891fc5 into main Dec 3, 2024
5 checks passed
@coyotte508 coyotte508 deleted the smaller-bites branch December 3, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants