[Inference] Factor makeRequestOptions logic #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
reviewed
Jan 15, 2025
| if (taskInfo) { | ||
| model = taskInfo.models[0].id; | ||
| let model: string; | ||
| if (!maybeModel) { |
There was a problem hiding this comment.
Maybe add something like
if (maybeModel && URL.parse(maybeModel)) {
throw new TypeError("model URLs are no longer supported, use endpointUrl instead")
}(or a regex check since URL.parse may not be supported on some safari devices)
coyotte508
approved these changes
Jan 15, 2025
julien-c
approved these changes
Jan 15, 2025
aykutkardas
pushed a commit
to gokayfem/huggingface.js
that referenced
this pull request
Jan 20, 2025
- Update the `makeRequestOptions` function to make the logic (hopefully) more readable; especially since huggingface#1077 - Stop support of model URLs - Update tapes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeRequestOptionsfunction to make the logic (hopefully) more readable; especially since [Inference] compatibility with third-party Inference providers #1077