[Inference] Update snippets #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
reviewed
Jan 23, 2025
julien-c
reviewed
Jan 23, 2025
julien-c
reviewed
Jan 23, 2025
julien-c
reviewed
Jan 23, 2025
cc @julien-c Goal is to easily review inference snippets changes by generating and committing the expected snippets that will be shown on the Hub. For now mostly adapter for `"hf-inference"` provider + added 1 example with `"replicate"`. In practice, we can add more examples once merged to #1129 **How to use:** 1. Go to `@tasks-gen` 2. Edit `packages/tasks-gen/scripts/generate-snippets-fixtures.ts` to add new examples 3. Run ``` pnpm run generate-snippets-fixtures ``` 4. Use git diff to check difference => commit them Afterwards, run tests (also done in CI) ``` pnpm test ``` **Note:** I haven't properly checked the snippets themselves. Will do it once merged when reviewing #1129. --------- Co-authored-by: Julien Chaumond <[email protected]>
julien-c
requested review from
Wauplin,
coyotte508,
gary149,
hanouticelina,
ngxson,
nsarrazin and
pcuenca
as code owners
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SBrandeis
commented
Jan 24, 2025
| content: `async function query(data) { | ||
| const client = new HfInference("${accessToken || `{API_TOKEN}`}"); | ||
| const image = await client.textToImage({ |
There was a problem hiding this comment.
root-level await statements are not supported by all the usual JS runtimes
| provider: InferenceProvider | ||
| ): InferenceSnippet[] => { | ||
| return [ | ||
| { |
There was a problem hiding this comment.
Should we keep this?
If yes, let's add install instructions to other snippets
There was a problem hiding this comment.
this = snippet.setup installation instructions
SBrandeis
changed the title
Wauplin
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.