handle folders in uploadFiles #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
coyotte508
commented
Apr 29, 2025
| * | ||
| * @default 5 | ||
| */ | ||
| maxFolderDepth?: number; |
There was a problem hiding this comment.
huggingface_hub uses glob cc @Wauplin @hanouticelina
Unfortunately support is only experimental for nodejs: https://nodejs.org/api/fs.html#fspromisesglobpattern-options
So using a maxFolderDepth (to avoid potential symlink recursions)
|
test failings unrelated to this PR, tests added in this PR pass |
Deep-unlearning
pushed a commit
that referenced
this pull request
May 13, 2025
If we want to expose a CLI for the JS client... cc @Pierrci for viz
coyotte508
added a commit
that referenced
this pull request
May 19, 2025
cc @Wauplin @hanouticelina for viz Internal context: https://huggingface.slack.com/archives/C0256NXF0A2/p1745930278721439?thread_ts=1741697907.530409&cid=C0256NXF0A2 Also add `createBranch` and `deleteBranch` functions Follow up to #1398 eg: ```console npm install -g @huggingface/hub export HF_TOKEN=... # Upload current dir to coyotte508/test-model in a new empty "build" branch hfjs create-branch coyotte508/test-model build --empty hfjs upload coyotte508/test-model --revision build ``` ## Testing go into `packages/hub` run `pnpm install` and run `sudo npm link` - then you can use `hfjs` or just do `node dist/cli.js upload ...` --------- Co-authored-by: Julien Chaumond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to expose a CLI for the JS client...
cc @Pierrci for viz