-
Notifications
You must be signed in to change notification settings - Fork 562
Added Radeon RX 9000 GPUs and Zen 5 9000 CPUs #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These correspond to the integrated GPU, not the CPU; but I guess it's ok.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reliable proxy for CPU performance that I can think of if we want to equate them to GPUs. INT8 / INT4 performance would have been a better metric, but then we'd end up with two different quantities. Best to leave CPUs out of the question.
Also, another problem I noticed: all Ryzen 9s are clubbed together, while chips like the Ryzen 9 9900X and the Ryzen 9 9950X3D have large differences in their performance. Here, I tested the cheapest and the costliest Ryzen 9, for example:
DeBERTa inference:
Granite Vision 3.2 2B 4-bit inference (image+text input):
In pure text input, the 9950X3D did 28.01 tok/s with this model. That's already 1/5th of what the RTX 5060 Ti 16 GB did (137.89 tok/s) in the same test, a card we are currently allocating 42.32x compute power by going for TFLOPS.
Hence, the 0.56 TFLOPS number for all Ryzen 9000 and 7000 series CPUs is indeed not fair or comparable with GPUs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, those tokens/second are probably coming from CPU inference, that's why I think it's interesting to use CPU numbers if we can (it's what people will use for ML inference). The problem is that CPU manufacturers don't usually publish tflops. We can compute them by taking into account the number of cores, the clock frequency and the number of "representative" operations (multiply-add, for example) per clock cycle. The latter, however, is difficult to find and requires diving into tech sheets, see this comment for an example.
I would suggest we merge this PR and revisit the CPU numbers you reported in a follow-up. Personally, I'm happy to include an estimate based on comparative performance if we can't find anything else!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that sounds good to me. We can visit this in a different conversation. Do let me know the best medium for the exchange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A draft PR or an issue is good imo! 🤗