-
Notifications
You must be signed in to change notification settings - Fork 563
feat(tasks): add tracking for hfendpoints images
#1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mfuntowicz Hmm, it feels weird to me to define Am I right to say that when someone deploys an Inference Endpoint from e.g. https://huggingface.co/hfendpoints-images/embeddings-sentence-transformers-cpu, it downloads a snapshot of the repo and then execute it on the server (using the Dockerfile/scripts)? And that you want to track the downloads for If that's the case, I would recommend to add an empty (for hfendpoints repos with already a config.json, it should be fine) |
| docsUrl: "https://hezarai.github.io/hezar", | ||
| countDownloads: `path:"model_config.yaml" OR path:"embedding/embedding_config.yaml"`, | ||
| }, | ||
| hfendpoints: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the images should show up here: https://huggingface.co/models?other=hfendpoints (whisper + sglang one too)
| prettyLabel: "Hugging Face Endpoints", | ||
| repoName: "hfendpoints", | ||
| repoUrl: "https://github.com/huggingface/hfendpoints", | ||
| countDownloads: `path:"handler.py"`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tho I wonder if we can't just add a config.json in the root of the repo and get usage stats automatically? IIRC IE clones the entire repo so config.json would be too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jinx 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or just use another log for telemetry (we have other systems at the infra level)
|
No big deal! I'm fine using an empty |
This PR attempts to track usage stats for endpoints deployed with
hfendpointslibrary