Fix MLX-VLM snippet and prio hf_xet for MLX models #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaibhavs10
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
Vaibhavs10
commented
May 19, 2025
| const mlx_unknown = (model: ModelData): string[] => [ | ||
| `# Download the model from the Hub | ||
| pip install huggingface_hub hf_transfer | ||
| pip install huggingface_hub[hf_xet] |
pcuenca
approved these changes
May 19, 2025
| pip install huggingface_hub[hf_xet] | ||
| export HF_HUB_ENABLE_HF_TRANSFER=1 | ||
| export HF_XET_HIGH_PERFORMANCE=1 |
Member
There was a problem hiding this comment.
I'd suggest we remove this to make everything simpler. In my experience it works fast enough without the flag.
| const mlxlm = (model: ModelData): string[] => [ | ||
| `# Make sure mlx-lm is installed | ||
| pip install --upgrade mlx-lm | ||
| # pip install --upgrade mlx-lm |
Vaibhavs10
commented
May 20, 2025
Contributor
Author
Vaibhavs10
left a comment
Vaibhavs10
left a comment
There was a problem hiding this comment.
failing tests look unrelated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to put pip install instructions in comments
and
hf_transfer->hf_xetfor MLX (since the models have moved over to xet backend.re: MLX VLM - currently there is a broken comment at the top here: https://huggingface.co/mlx-community/gemma-3-27b-it-qat-4bit?library=mlx