Skip to content

[tiny-agents] Handle env variables in tiny-agents (JS client) #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wauplin merged 2 commits into from
Jun 3, 2025
Merged

[tiny-agents] Handle env variables in tiny-agents (JS client) #1501

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e81f6ed
Handle env variables in tiny-agents
Wauplin May 28, 2025
d154e3e
Also do it for HTTP headers
julien-c Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/tiny-agents/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ async function main() {
}
}
}
if ((server.type === "http" || server.type === "sse") && server.config.options?.requestInit?.headers) {
for (const [key, value] of Object.entries(server.config.options.requestInit.headers)) {
if (value.includes(envSpecialValue)) {
inputVars.add(key);
}
}
}
}

if (inputVars.size === 0) {
Expand Down Expand Up @@ -156,6 +163,29 @@ async function main() {
}
}
}
if ((server.type === "http" || server.type === "sse") && server.config.options?.requestInit?.headers) {
for (const [key, value] of Object.entries(server.config.options.requestInit.headers)) {
if (value.includes(envSpecialValue)) {
if (userInput) {
server.config.options.requestInit.headers[key] = value.replace(envSpecialValue, userInput);
} else {
const valueFromEnv = process.env[key] || "";
server.config.options.requestInit.headers[key] = value.replace(envSpecialValue, valueFromEnv);
if (valueFromEnv) {
stdout.write(ANSI.GREEN);
stdout.write(`Value successfully loaded from '${key}'`);
stdout.write(ANSI.RESET);
stdout.write("\n");
} else {
stdout.write(ANSI.YELLOW);
stdout.write(`No value found for '${key}' in environment variables. Continuing.`);
stdout.write(ANSI.RESET);
stdout.write("\n");
}
}
}
}
}
Comment on lines +166 to +188
Copy link
Member

@julien-c julien-c Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Claude 4 generated

Copy link
Contributor Author

@Wauplin Wauplin Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 well Claude could have done some refactoring efforts instead of duplicating the entire "load from env" logic ^^

}
}

Expand Down
21 changes: 20 additions & 1 deletion packages/tiny-agents/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ export const ServerConfigSchema = z.discriminatedUnion("type", [
url: z.union([z.string(), z.string().url()]),
options: z
.object({
/**
* Customizes HTTP requests to the server.
*/
requestInit: z
.object({
headers: z.record(z.string()).optional(),
})
.optional(),
Comment on lines +24 to +31
Copy link
Member

@julien-c julien-c Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semi-related comment for @Wauplin, @hanouticelina and @evalstate:

i am starting to think we should have gone with a simplified configuration schema (the one from VS Code, probably), rather than be more explicit and use the types from the MCP SDK, given here for instance, we need to nest the headers quite a bit inside of the config.

Maybe for a v2 we'll change this! no rush, though

Copy link
Contributor Author

@Wauplin Wauplin Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well making the switch to something more standard right now is probably better (not in this PR but as follow-up). Agree the config nesting is not really needed

/**
* Session ID for the connection. This is used to identify the session on the server.
* When not provided and connecting to a server that supports session IDs, the server will generate a new session ID.
Expand All @@ -34,7 +42,18 @@ export const ServerConfigSchema = z.discriminatedUnion("type", [
type: z.literal("sse"),
config: z.object({
url: z.union([z.string(), z.string().url()]),
options: z.object({}).optional(),
options: z
.object({
/**
* Customizes HTTP requests to the server.
*/
requestInit: z
.object({
headers: z.record(z.string()).optional(),
})
.optional(),
})
.optional(),
}),
}),
]);
Expand Down