Harmonize inferenceProviderMapping additional parameter in modelInfo / listModel #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
requested review from
SBrandeis,
coyotte508,
hanouticelina and
julien-c
as code owners
Contributor
Author
|
CI failing test seems unrelated so PR is ready to be reviewed. This PR introduces a breaking change in the return type of listModels / modelInfo but I do think it's for the best. Once this PR is merged and published, both clients will be compatible with current and future APIs. |
julien-c
reviewed
Jun 4, 2025
julien-c
approved these changes
Jun 4, 2025
Member
julien-c
left a comment
julien-c
left a comment
There was a problem hiding this comment.
read this quite superficially but lgtm
coyotte508
approved these changes
Jun 4, 2025
Contributor
Author
|
Merging it now as failing test seems unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to huggingface/huggingface_hub#3022 in Python.
Main problem is that
expand[]=inferenceProviderMappingdo not return the same data structure when getting model info or listing models. We will fix this in ~3 months (?) but in the meantime we want a client compatible with both current and future structure (see huggingface/huggingface_hub#3022 for more details).TODO:
@huggingface/inference