Skip to content

Add SeedVR to model-libraries.ts #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025
Merged

Add SeedVR to model-libraries.ts #1523

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f5fcee
Update model-libraries.ts
IceClear Jun 11, 2025
930260f
Merge branch 'main' into main
IceClear Jun 11, 2025
09bfc00
split repos
IceClear Jun 11, 2025
da767df
finish
IceClear Jun 11, 2025
4ed373d
Update packages/tasks/src/model-libraries.ts
Wauplin Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/tasks/src/model-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
filter: false,
countDownloads: `path:"llm_config.json"`,
},
"seedvr-models": {
prettyLabel: "SeedVR",
repoName: "SeedVR",
repoUrl: "https://github.com/ByteDance-Seed/SeedVR/",
filter: false,
countDownloads: `path_extension:"pth"`,
Copy link
Contributor

@Wauplin Wauplin Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is usually highly recommended to have 1 repo per model instead of 1 repo with 4 models. By doing so, you'll be able to get a download count per model and hence better analytics to understand which model is the most popular. Also, it improves discoverability for users on the Hub. And finally if some other users are interested in pushing their own models using the SeedVR library, they can also do it and follow the same repo structure as yours (which is currently not the case).

(not a obligation though, just a strong recommendation)

Copy link
Contributor

@Wauplin Wauplin Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case, I would rename the repo from ByteDance-Seed/SeedVR-Models to e.g. ByteDance-Seed/SeedVR2-7b for seedvr2_ema_7b.pth

Copy link
Contributor Author

@IceClear IceClear Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wauplin I have split the repos into four following your suggestions. Kindly have a check. Thx.

},
ben2: {
prettyLabel: "BEN2",
repoName: "BEN2",
Expand Down