Add univa to models #1526
Add univa to models #1526
Conversation
merveenoyan
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
Vaibhavs10
left a comment
Vaibhavs10
left a comment
There was a problem hiding this comment.
LGTM! requires the tag to be merged on the hub before merge: https://huggingface.co/LanguageBind/UniWorld-V1/blob/main/README.md?code=true#L3
| "univa": { | ||
| prettyLabel: "univa", | ||
| repoName: "univa", |
There was a problem hiding this comment.
| "univa": { | |
| prettyLabel: "univa", | |
| repoName: "univa", | |
| "uniworld": { | |
| prettyLabel: "UniWorld", | |
| repoName: "UniWorld", |
Shouldn't the library be named UniWorld instead to follow the repo naming convention? I feel it would be more natural that way
There was a problem hiding this comment.
the library itself was called univa, i.e. import univa, the model is loaded from there. if the authors choose to train new models loaded with this code it would be more unified imo
| countDownloads: `path_extension:"pt"`, | ||
| snippets: snippets.ultralytics, | ||
| }, | ||
| "univa": { |
There was a problem hiding this comment.
as mentioned by @Vaibhavs10 let's get the model listed under https://huggingface.co/models?other=uniworld (or https://huggingface.co/models?other=univa) before shipping this PR
There was a problem hiding this comment.
before this PR @NielsRogge has opened this PR https://huggingface.co/LanguageBind/UniWorld-V1/discussions/3/files they haven't responded, pinged them again
There was a problem hiding this comment.
before this PR @NielsRogge has opened this PR https://huggingface.co/LanguageBind/UniWorld-V1/discussions/3/files they haven't responded, pinged them again
Done! Thanks!
| repoUrl: "https://github.com/PKU-YuanGroup/UniWorld-V1", | ||
| snippets: snippets.univa, | ||
| filter: true, | ||
| countDownloads: `path_extension:"safetensors"`, |
There was a problem hiding this comment.
Looks like the repo already have a config.json file so would be good to keep the counting on that file (if loaded at each .from_pretrained). This is the default rule if we don't set one.
Problem with counting path_extension:"safetensors" is that it's non-canonical + will count 17 downloads each time a user downloads the repo (given the 17 shards). (taken from files section)
There was a problem hiding this comment.
fixed this, thanks for the heads up!
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
Vaibhavs10
left a comment
Vaibhavs10
left a comment
There was a problem hiding this comment.
Shows up here now: https://huggingface.co/models?other=univa
Feel free to merge whenever convenient @merveenoyan 🤗
@Vaibhavs10 @linoytsaban as discussed