-
Notifications
You must be signed in to change notification settings - Fork 551
Add ConTextTab model #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConTextTab model #1528
Changes from 4 commits
edef2d3
478e81f
8049ece
003cb98
18ea01b
17a6b10
43696e8
4a6a7f1
e0c04c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -208,6 +208,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |
| repoUrl: "https://github.com/Unbabel/COMET/", | ||
| countDownloads: `path:"hparams.yaml"`, | ||
| }, | ||
| contexttab: { | ||
Wauplin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| prettyLabel: "ConTextTab", | ||
| repoName: "contexttab", | ||
Wauplin marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| repoUrl: "https://github.com/SAP-samples/contexttab", | ||
| countDownloads: `path:"l2/base.pt"`, | ||
|
||
| snippets: snippets.contexttab, | ||
| }, | ||
| cosmos: { | ||
| prettyLabel: "Cosmos", | ||
| repoName: "Cosmos", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, these 3 snippets don't really show how to use the model in the repo. Adding snippets would be very beneficial if contexttab had a
from_pretrainedmethod for instance to load a pre-trained model from a repo_id. By doing so, you allow users to share their own weights in new repos which will result in personalized snippets to reuse their model. Does that make sense to you?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I understand the confusion! I've omitted the default parameters, but both
ConTextTabClassifierandConTextTabRegressorshown in the example use the HF hub model weights, taking acheckpointandcheckpoint_revisionargument pointing to the HF repo. I can add it to be more verbose if you like.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wauplin : done ✅