Add song generation as a library #1543
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
Vaibhavs10
approved these changes
Jun 20, 2025
Member
Vaibhavs10
left a comment
Vaibhavs10
left a comment
There was a problem hiding this comment.
Looks okay to me except the comment re: tag
| filter: false, | ||
| countDownloads: `path:"soloaudio_v2.pt"`, | ||
| }, | ||
| "song-generation": { |
Member
There was a problem hiding this comment.
haha, song-generation is a bit too generic tag no? I wonder if we should change it a bit.
Vaibhavs10
reviewed
Jun 20, 2025
Member
There was a problem hiding this comment.
Duplicate of this: https://github.com/huggingface/huggingface.js/pull/1542/files
let's prio the other one.
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds song-generation by Tencent as a dedicated library: https://huggingface.co/tencent/SongGeneration
cc @apolinario @linoytsaban