Skip to content

Conversation

quanghuynt14
Copy link
Contributor

@quanghuynt14 quanghuynt14 commented Jun 28, 2025

Hello there πŸ‘‹

It's my first time contributing. I tried to set up the project with pnpm and got error when running the tests:

 ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
β”‚  FAIL  src/lib/list-datasets.spec.ts > listDatasets > should list datasets from hf-doc-builder
β”‚ AssertionError: expected [ { …(7) }, { …(7) } ] to deeply equal [ { …(7) }, { …(7) } ]
β”‚ - Expected
β”‚ + Received
β”‚   Array [
β”‚     Object {
β”‚       "downloads": 0,
β”‚       "gated": false,
β”‚ -     "id": "6356b19985da6f13863228bd",
β”‚ +     "id": "636a1b69f2f9ec4289c4c19e",
β”‚       "likes": 0,
β”‚ -     "name": "hf-doc-build/doc-build",
β”‚ +     "name": "hf-doc-build/doc-build-dev",
β”‚       "private": false,
β”‚       "updatedAt": 1970-01-01T00:00:00.000Z,
β”‚     },
β”‚     Object {
β”‚       "downloads": 0,
β”‚       "gated": false,
β”‚ -     "id": "636a1b69f2f9ec4289c4c19e",
β”‚ +     "id": "6356b19985da6f13863228bd",
β”‚       "likes": 0,
β”‚ -     "name": "hf-doc-build/doc-build-dev",
β”‚ +     "name": "hf-doc-build/doc-build",
β”‚       "private": false,
β”‚       "updatedAt": 1970-01-01T00:00:00.000Z,
β”‚     },
β”‚   ]
β”‚  ❯ src/lib/list-datasets.spec.ts:26:24
β”‚      24|   }
β”‚      25| 
β”‚      26|   expect(results).deep.equal([
β”‚        |                        ^
β”‚      27|    {
β”‚      28|     id: "6356b19985da6f13863228bd",
β”‚ ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯
β”‚  Test Files  1 failed | 39 passed (40)
β”‚       Tests  1 failed | 135 passed (136)
β”‚    Start at  02:32:04
β”‚    Duration  14.37s (transform 650ms, setup 3ms, collect 2.44s, tests 65.94s, environment 3ms, prepare 2.74s)

So I fix it.

@quanghuynt14 quanghuynt14 requested a review from coyotte508 as a code owner June 28, 2025 00:40
@quanghuynt14 quanghuynt14 changed the title fix: test list datasets fix(hub): test list datasets Jun 28, 2025
@quanghuynt14 quanghuynt14 requested a review from coyotte508 June 30, 2025 11:55
@quanghuynt14
Copy link
Contributor Author

@coyotte508 we had an error in the test src/utils/XetBlob.spec.ts and CI didn't pass. What can we do to merge this PR?

@coyotte508 coyotte508 merged commit 4e3da78 into huggingface:main Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants