-
Notifications
You must be signed in to change notification settings - Fork 493
Add LVFace library #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GitHup2016yjh
wants to merge
7
commits into
huggingface:main
Choose a base branch
from
GitHup2016yjh:dev_lvface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add LVFace library #1685
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
70d4f83
add Library
GitHup2016yjh 81ec481
Merge branch 'main' into dev_lvface
GitHup2016yjh ce6e472
Update Add LVFace library
GitHup2016yjh 2da0490
Update LVFace library
GitHup2016yjh 4943378
Update packages/tasks/src/model-libraries.ts
pcuenca 35a49f2
Merge branch 'main' into dev_lvface
pcuenca e5ae248
Update LVFace library
GitHup2016yjh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add imports 🥹 feel free to remove comments to make it more minimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes^ - let's make the snippets complete and minimal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excuse me, would it be necessary for me to delete some of the comments to reduce the number of lines taken by them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in general we keep them minimal, so lesser the better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reminder. I have already compressed it to just one line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the confusion here @GitHup2016yjh - what we meant by minimal snippet was to have something that enables people to test your model in say a Google Colab without looking at your GitHub repo or documentation for more details.
You can see couple of examples of this in the rest of the snippets in the same file.
An ideal snippet has three main parts:
Let me know if this is not clear - happy to elaborate more.
Thanks again for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reminder. I have revised this part of the content. Is it correct now?