Skip to content

Add BBoxMaskPose to download count #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add BBoxMaskPose to download count #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/tasks/src/model-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
filter: false,
countDownloads: `path:"llm_config.json"`,
},
bboxmaskpose: {
prettyLabel: "BBoxMaskPose",
repoName: "BBoxMaskPose",
repoUrl: "https://github.com/MiraPurkrabek/BBoxMaskPose",
filter: false,
countDownloads: `path_extension:"pth"`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the three models used for inference or is one used at a time?

The reason I ask is, there are currently three different model checkpoint in the repo: https://huggingface.co/vrg-prague/BBoxMaskPose/tree/main

and the download counter will +=1 download counter for each hit, i.e. if all three are used for single inference, it'd result in +=3 which would make downloads inaccurate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review, @Vaibhavs10 .

Yes, all 3 models are needed to run the whole method -- it consists of their iterative usage and smart integration. However, all models could also work as standalone models if the user does not want to use them in the loop.

Therefore, it make sense to me to have all models in the same repo as they are connected to the same paper and together form the main method.

On the other hand, it also make sense to count downloads for each model. A user can download only one of the models and it should be counted.

Let me know if you see it differently or if I should change anything.

Thank you

},
ben2: {
prettyLabel: "BEN2",
repoName: "BEN2",
Expand Down